Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Added start_date and end_date #190

Merged
merged 1 commit into from
May 4, 2022
Merged

Backend: Added start_date and end_date #190

merged 1 commit into from
May 4, 2022

Conversation

rabinadk1
Copy link
Member

  • Remove the day and the month filters
  • start_date is inclusive and end_date is exclusive
  • The day filter corresponds to both dates being the same
  • The month filter corresponds to both dates being the start of the consecutive months.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #190 (a88ade1) into main (8659303) will decrease coverage by 0.30%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   79.53%   79.23%   -0.31%     
==========================================
  Files          28       28              
  Lines         782      780       -2     
==========================================
- Hits          622      618       -4     
- Misses        160      162       +2     
Impacted Files Coverage Δ
server/app/tweets_common/routes.py 55.55% <0.00%> (-4.45%) ⬇️
server/app/pseudo_tweets/routes.py 60.37% <50.00%> (-0.74%) ⬇️
server/app/tweets/routes.py 64.28% <50.00%> (-0.84%) ⬇️
server/app/tweets_common/helper_functions.py 60.75% <63.15%> (+8.25%) ⬆️
server/app/tweets_common/types.py 0.00% <0.00%> (-31.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8659303...a88ade1. Read the comment docs.

@rabinadk1
Copy link
Member Author

This PR should be merged to the main only after changing the code correspondingly in the frontend.

@samipism samipism merged commit f148e82 into main May 4, 2022
@samipism samipism deleted the range_filter branch May 4, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants